Fix/improve smtp error return #22
Closed
+1
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolljee
approved these changes
Sep 24, 2024
etrousset
approved these changes
Sep 24, 2024
etrousset
requested changes
Sep 24, 2024
So I should ensure that body is define too ? |
Yes, this log will be useless if body isn't defined |
|
close due to duplication with #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will avoid to have undefined errors :
example:
{"level":"error","message":"2024-09-24 10-45-08 [LOG:ERROR] [knode-responsive-gaia-74820] [5a9f83b3-2ad1-4e0d-bdfd-4da0977f8fe3] [workflows] [tenant-chillnet_tenant-chill] Cannot execute workflow \"workflow--scheduled-report-1723483109074-0\": ExternalServiceError: SMTP undefined\n at new ExternalServiceError (/var/app/node_modules/kuzzle/lib/kerror/errors/externalServiceError.js:27:9)\n at SMTPClient.sendEmail (/var/app/node_modules/kuzzle-plugin-hermes-messenger/dist/lib/messenger-clients/SMTPClient.js:36:23)\n at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n at async SMTPController.sendEmail (/var/app/node_modules/kuzzle-plugin-hermes-messenger/dist/lib/controllers/SMTPController.js:42:9)\n at async Funnel.executePluginRequest (/var/app/node_modules/kuzzle/lib/api/funnel.js:759:14)\n at async FunnelProtocol.query (/var/app/node_modules/kuzzle/lib/core/shared/sdk/funnelProtocol.js:95:24)\n at async ScheduledDashboardExportTask.sendDashboardExport (/var/app/node_modules/@kuzzleio/iot-platform-backend/dist/modules/dashboard/tasks/ScheduledDashboardExportTask.js:62:9)\n at async ScheduledDashboardExportTask.run (/var/app/node_modules/@kuzzleio/iot-platform-backend/dist/modules/dashboard/tasks/ScheduledDashboardExportTask.js:97:9)\n at async TaskExecutor.execute (/var/app/node_modules/@kuzzleio/plugin-workflows/dist/lib/actions/task/TaskExecutor.js:27:13)\n at async ActionsExecutor.execute (/var/app/node_modules/@kuzzleio/plugin-workflows/dist/lib/actions/ActionsExecutor.js:38:25)\n at async SchedulerTrigger.tryExecuteOnNode (/var/app/node_modules/@kuzzleio/plugin-workflows/dist/lib/triggers/scheduler/SchedulerTrigger.js:206:17)\n at async Promise.all (index 0)\n at async Timeout._onTimeout (/var/app/node_modules/@kuzzleio/plugin-workflows/dist/lib/triggers/scheduler/SchedulerTrigger.js:167:17)"}