Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the stall controller #796

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xThaid
Copy link
Contributor

@xThaid xThaid commented Jan 27, 2025

It made a few changes that will be useful in the future work on the frontend:

  • I decoupled the stall logic from the fetch unit
  • Func units call the resume method instead of defining it

todo:

  • comments
  • fix the test

One test in test_core is failing because of kuznia-rdzeni/transactron#45

@xThaid xThaid added enhancement New feature or request refactor Doesn't change functionality, but makes stuff nicer benchmark Benchmarks should be run for this change labels Jan 27, 2025
@xThaid xThaid marked this pull request as draft January 27, 2025 01:56
Copy link

Benchmarks summary

Performance benchmarks

aha-mont64 crc32 minver nettle-sha256 nsichneu slre statemate ud
0.417 (0.000) 0.532 (0.000) ▲ 0.373 (+0.000) ▲ 0.632 (+0.000) ▲ 0.359 (+0.000) ▲ 0.291 (+0.000) 0.328 (0.000) 0.443 (0.000)

You can view all the metrics here.

Synthesis benchmarks (basic)

Device utilisation: (ECP5) LUTs used as DFF: (ECP5) LUTs used as carry: (ECP5) LUTs used as ram: (ECP5) Max clock frequency (Fmax)
▼ 13950 (-453) ▼ 4293 (-38) 1424 (0) ▼ 1104 (-32) ▲ 51 (+2)

Synthesis benchmarks (full)

Device utilisation: (ECP5) LUTs used as DFF: (ECP5) LUTs used as carry: (ECP5) LUTs used as ram: (ECP5) Max clock frequency (Fmax)
▼ 24805 (-1187) ▼ 6783 (-38) 1940 (0) ▼ 1632 (-32) ▼ 40 (-3)

@xThaid xThaid removed the benchmark Benchmarks should be run for this change label Jan 27, 2025
@xThaid xThaid force-pushed the 20250126-stall_ctrl branch from d405062 to bb96f40 Compare January 30, 2025 00:11
@xThaid xThaid marked this pull request as ready for review January 30, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Doesn't change functionality, but makes stuff nicer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant