-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl dependency list flag #2543
base: main
Are you sure you want to change the base?
Changes from all commits
aba722a
507ef13
546c1c9
8df95e7
d0bba73
3831674
725cf84
65da4ab
b712fe8
c1cd1fc
554b754
18c2591
7e56e5b
24bbebb
09e90ee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -531,6 +531,41 @@ func (enclaveCtx *EnclaveContext) GetStarlarkRun(ctx context.Context) (*kurtosis | |
return response, nil | ||
} | ||
|
||
func (enclaveCtx *EnclaveContext) GetStarlarkPackagePlanYaml(ctx context.Context, packageId string, serializedParams string, dependenciesOnly bool) (*kurtosis_core_rpc_api_bindings.PlanYaml, error) { | ||
serializedParams, err := maybeParseYaml(serializedParams) | ||
if err != nil { | ||
return nil, stacktrace.Propagate(err, "An error occurred when parsing YAML args for package '%v'", serializedParams) | ||
} | ||
response, err := enclaveCtx.client.GetStarlarkPackagePlanYaml(ctx, &kurtosis_core_rpc_api_bindings.StarlarkPackagePlanYamlArgs{ | ||
PackageId: packageId, | ||
SerializedParams: &serializedParams, | ||
RelativePathToMainFile: nil, | ||
MainFunctionName: nil, | ||
DependenciesOnly: &dependenciesOnly, | ||
}) | ||
if err != nil { | ||
return nil, stacktrace.Propagate(err, "An error occurred while getting the starlark package plan yaml run.") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the "....run" at the end of the sentence perhaps a copy-paste that wasn't deleted? (my understanding is this returns the actual YAML; feel free to ignore this comment if not useful) |
||
} | ||
return response, nil | ||
} | ||
|
||
func (enclaveCtx *EnclaveContext) GetStarlarkScriptPlanYaml(ctx context.Context, serializedScript string, serializedParams string, dependenciesOnly bool) (*kurtosis_core_rpc_api_bindings.PlanYaml, error) { | ||
serializedParams, err := maybeParseYaml(serializedParams) | ||
if err != nil { | ||
return nil, stacktrace.Propagate(err, "An error occurred when parsing YAML args for package '%v'", serializedParams) | ||
} | ||
response, err := enclaveCtx.client.GetStarlarkScriptPlanYaml(ctx, &kurtosis_core_rpc_api_bindings.StarlarkScriptPlanYamlArgs{ | ||
SerializedScript: serializedScript, | ||
SerializedParams: &serializedParams, | ||
MainFunctionName: nil, | ||
DependenciesOnly: &dependenciesOnly, | ||
}) | ||
if err != nil { | ||
return nil, stacktrace.Propagate(err, "An error occurred while getting the last starlark script plan yaml run.") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question |
||
} | ||
return response, nil | ||
} | ||
|
||
// ==================================================================================================== | ||
// | ||
// Private helper methods | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be s/serializedParams/packageId/?