Skip to content

Commit

Permalink
Use unsigned int for data comparison inside ASSERT_GE()
Browse files Browse the repository at this point in the history
Buildbot reports warning message "C4018: '>=' : signed/unsigned
mismatch" if the arguments of function ASSERT_GE() have different types.
Since runtimes.size() returns an unsigned int value, this CL changes the
other value to the same type for comparison.
  • Loading branch information
shaochangbin committed Sep 18, 2013
1 parent e79321c commit f93bf8d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion application/test/application_main_document_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ IN_PROC_BROWSER_TEST_F(ApplicationMainDocumentBrowserTest, MainDocument) {
content::RunAllPendingInMessageLoop();
const xwalk::RuntimeList& runtimes = RuntimeRegistry::Get()->runtimes();
// At least the main document's runtime exist after launch.
ASSERT_GE(runtimes.size(), 1);
ASSERT_GE(runtimes.size(), 1U);

Runtime* main_runtime = runtimes[0];
xwalk::RuntimeContext* runtime_context = main_runtime->runtime_context();
Expand Down

0 comments on commit f93bf8d

Please sign in to comment.