Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More complete cd_info files #19

Merged
merged 11 commits into from
Oct 26, 2024
Merged

More complete cd_info files #19

merged 11 commits into from
Oct 26, 2024

Conversation

kuriwaki
Copy link
Owner

@kuriwaki kuriwaki commented Oct 26, 2024 •
edited
Loading

This PR:

  • Fixes missingness in 2008 by using Kiernan Park-Egan's file, closes cd_info_long and cd_info_2008 missing denominator #18
  • Changes pct_trump etc.. values to two-party voteshare, as advertised. Previously they were using share of total votes including third party and undervotes, which slightly underestimated the two-party voteshare
  • Added presvotes_DR as a denominator value for D + R. This is useful for translating percents into raw vote counts
  • Call the Rd page for cd_info cd_info instead of relying on cd_info_2018

@kuriwaki kuriwaki merged commit d705ebd into main Oct 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cd_info_long and cd_info_2008 missing denominator
1 participant
@kuriwaki