ci(github): fix checklist PR comment #12180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrel: #11654 #11666 Signed-off-by: Charly Molter <[email protected]>
lahabana
requested review from
slonka and
bartsmykla
and removed request for
a team
This is necessary in order to safely run with pull_request_target we simply don't checkout any code so this workflow can execute safely on forks Signed-off-by: Charly Molter <[email protected]>
lahabana
added
the
ci/skip-test
slonka
approved these changes
Dec 6, 2024
Signed-off-by: Charly Molter <[email protected]>
|
Here's an example: just checking both files are the same: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Implementation information
To be able to leave a comment on a pull request we need
pull_request: writepermissions. Unfortunately github won't allow this level of permissions on PRs coming from forks.The way to get the permissions is to use
pull_request_targetas a triggering event.However, there are a lot of possible attack vectors when checking out code when using this event.
Therefore we inline commitlint.config.js inside the action to not have to checkout any code and be able to run this action safely.
Supporting documentation
xrel: #11654 #11666
superseeds: #11674
pull_request_target: - Resource not accessible by integration marocchino/sticky-pull-request-comment#930part of: https://github.com/Kong/team-mesh/issues/302