Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the previous cop is completely overwritten when binding op #336

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

qclc
Copy link
Collaborator

@qclc qclc commented Sep 3, 2024

No description provided.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 58.66667% with 31 lines in your changes missing coverage. Please review.

Project coverage is 33.94%. Comparing base (80e8f73) to head (f16c725).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/override/util.go 50.00% 4 Missing and 10 partials ⚠️
pkg/controllers/util/overridepolicy.go 44.44% 5 Missing and 5 partials ⚠️
pkg/util/pod/pod.go 71.42% 2 Missing and 2 partials ⚠️
.../controllers/override/overridepolicy_controller.go 0.00% 2 Missing ⚠️
pkg/controllers/sync/resource.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   33.50%   33.94%   +0.43%     
==========================================
  Files         155      156       +1     
  Lines       14617    14723     +106     
==========================================
+ Hits         4897     4997     +100     
+ Misses       9210     9204       -6     
- Partials      510      522      +12     
Flag Coverage Δ
unittests 33.94% <58.66%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Poor12
Copy link
Collaborator

Poor12 commented Sep 3, 2024

/lgtm. Just a lint error.

pkg/controllers/override/util.go Outdated Show resolved Hide resolved
pkg/util/pod/pod.go Show resolved Hide resolved
@mrlihanbo mrlihanbo merged commit b29bb15 into kubewharf:main Sep 3, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants