feat: add helm chart for kubeadmiral #325
Conversation
qclc
force-pushed
the
feat-add-helm
branch
2 times, most recently
from
57ae9c0
to
d88585b
Compare
| @@ -0,0 +1,62 @@ | |||
| --- | |||
There was a problem hiding this comment.
Are these files copied from the repo? Should we have a separate script to build the helm chart in CI and copy the CRD files to this directory in the CI instead of committing all files twice?
There was a problem hiding this comment.
There is a generated script file(hack/generate-groups.sh) for CRD, which has been updated here. It will be synchronized and updated to the Helm chart directory every time CRD is generated.
There was a problem hiding this comment.
If you insist to commit the generated files twice, please add the new paths to .gitattributes to mark them as generated.
There was a problem hiding this comment.
The .gitattributes and typos.toml has already been updated.
qclc
force-pushed
the
feat-add-helm
branch
3 times, most recently
from
05a2433
to
fced5da
Compare
| - /bin/sh | ||
| - -c | ||
| - | | ||
| bash <<'EOF' |
There was a problem hiding this comment.
Any particular reason we can't just [/bin/bash, -c, "set -ex... EOF"] here?
No description provided.