feat: add prometheus metrics #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary-lgy
reviewed
Aug 7, 2023
pkg/stats/stats.go
Outdated
| if s.logMetrics { | ||
| fields := convertTToFields(tags) | ||
| msg := fmt.Sprintf("counter %s.%s + %v", s.prefix, name, val) | ||
| msg := fmt.Sprintf("rate %s_%s + %v", s.prefix, name, val) | ||
| log.WithFields(fields).Infoln(msg) |
There was a problem hiding this comment.
Should we consider removing the logrus dependency?
gary-lgy
reviewed
Aug 7, 2023
| ctx, keyedLogger := logging.InjectLoggerValues(ctx, "origin", "reconcileLeader", "type", key.sourceGK.String(), "key", key.ObjectSourceKey()) | ||
| startTime := time.Now() | ||
|
|
||
| keyedLogger.V(3).Info("Starting reconcileLeader") | ||
| defer func() { | ||
| c.metrics.Duration(fmt.Sprintf("follower-controller-%s.latency", key.sourceGK.String()), startTime) | ||
| c.metrics.Duration( |
There was a problem hiding this comment.
Should we add these KV to all controller reconcile metrics?
mrlihanbo
force-pushed
the
feat/promethus
branch
from
b84636f
to
ec9e329
Compare
Poor12
reviewed
Aug 7, 2023
| flags.BoolVar(&o.PrometheusMetrics, "export-prometheus", true, "Whether to expose metrics through a prometheus endpoint") | ||
| flags.StringVar(&o.PrometheusAddr, "prometheus-addr", "", "prometheus collector address") | ||
| flags.Uint16Var(&o.PrometheusPort, "prometheus-port", 9090, "prometheus collector port") | ||
| flags.StringToStringVar( |
There was a problem hiding this comment.
Why do we need to pass quantiles as parameters to the controller? Kind of rare.
| @@ -123,6 +128,16 @@ func (o *Options) AddFlags(flags *pflag.FlagSet, allControllers []string, disabl | |||
| flags.BoolVar(&o.EnablePodPruning, "enable-pod-pruning", false, "Enable pod pruning for pod informer. "+ | |||
| "Enabling this can reduce memory usage of the pod informer, but will disable pod propagation.") | |||
| o.addKlogFlags(flags) | |||
|
|
|||
| flags.BoolVar(&o.PrometheusMetrics, "export-prometheus", true, "Whether to expose metrics through a prometheus endpoint") | |||
| flags.StringVar(&o.PrometheusAddr, "prometheus-addr", "", "prometheus collector address") | |||
There was a problem hiding this comment.
Suggested change
| flags.StringVar(&o.PrometheusAddr, "prometheus-addr", "", "prometheus collector address") | |
| flags.StringVar(&o.PrometheusAddr, "prometheus-addr", "", "Prometheus collector address") |
Capitalize the first letter of the description.
mrlihanbo
force-pushed
the
feat/promethus
branch
from
ec9e329
to
8165a9b
Compare
gary-lgy
approved these changes
Aug 7, 2023
mrlihanbo
merged commit 7b3fe83
into
kubewharf:refactor/unified-federated-type
5 checks passed
miraclejzd
pushed a commit
to miraclejzd/kubeadmiral
that referenced
this pull request
Jan 3, 2024
feat: add prometheus metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.