fix: informer-manager cache sync backoff #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limhawjia
force-pushed
the
fix-informer-manager-cache-sync-wait
branch
from
6d5403f
to
74fa3d1
Compare
mrlihanbo
approved these changes
Aug 3, 2023
gary-lgy
approved these changes
Aug 3, 2023
limhawjia
force-pushed
the
fix-informer-manager-cache-sync-wait
branch
from
74fa3d1
to
bbb2c0b
Compare
limhawjia
merged commit b579ac5
into
kubewharf:refactor/unified-federated-type
1 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the use of a backoff when waiting for caches to sync for new informers in the
InformerManager. This allows us to reduce the noise and processing of faulty informers. E.g. when a cluster is down or when a cluster does not have a CRD installed.It also introduces a separate backoff for retries on success and retries on errors for the
ReconcileWorker, which is used by the Federate controller.