feat: integrate pod informer to federated informer manager #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limhawjia
force-pushed
the
feat-integrate-pod-informer-to-federated-informer-manager
branch
3 times, most recently
from
1075524
to
44a53eb
Compare
limhawjia
force-pushed
the
feat-integrate-pod-informer-to-federated-informer-manager
branch
from
44a53eb
to
513a40d
Compare
limhawjia
merged commit 513a40d
into
kubewharf:refactor/unified-federated-type
1 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integartes the old custom pod informer in
FederatedClientintoFederatedInformerManager. This is in preparation for the FederatedCluster controller refactor.Additionally,
FederatedInformerManagernow also waits for an initial snapshot of clusters to be reconciled and their respectiveInformerManagersto be synced before returning true in its ownHasSyncedmethod. This reduces the amount of false errors on start-up where hostInformerManager's view of FTCs is out of sync with the memberInformerManagers' view.