New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: sync controller #167

Merged

gary-lgy merged 57 commits into kubewharf:refactor/unified-federated-type from gary-lgy:unified-sync-controller

Jul 31, 2023

Member

gary-lgy commented Jul 18, 2023

No description provided.

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/resource.go Show resolved Hide resolved

mrlihanbo reviewed

View reviewed changes

pkg/controllers/sync/accessor.go Outdated Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/controller.go Outdated Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/controller.go Outdated Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/controller.go Outdated Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/controller.go Outdated Show resolved Hide resolved

gary-lgy force-pushed the unified-sync-controller branch 4 times, most recently from b0035e0 to 48e481d Compare

July 27, 2023 05:01

limhawjia reviewed

View reviewed changes

pkg/controllers/override/util_test.go Outdated Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/version/manager.go Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/version/manager.go Outdated Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/version/manager.go Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/version/manager.go Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/version/manager.go Outdated Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/resource.go Outdated Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/resource.go Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/resource.go Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/placement.go Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/dispatch/managed.go Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/dispatch/managed.go Outdated Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/accessor.go Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/accessor.go Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/util/meta/meta.go Outdated Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/util/propagatedversion/propagatedversion.go Outdated Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/controller.go Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/controller.go Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/controller.go Show resolved Hide resolved

limhawjia reviewed

View reviewed changes

pkg/controllers/sync/controller.go Outdated Show resolved Hide resolved

gary-lgy added 25 commits

July 31, 2023 05:55


          fix(status): make it compilable

687789d


          fix(sync): revert deletion of source-generation annotation

cf14752


          chore(status): remove stale structs

3fed307


          chore: fix wrong import

4ecd638


          fix(sync): nil pointer dereference

fa99420


          fix(override): nil pointer derefenrence

fd3e825


          fix(sync): retain replicas test

a1afa06


          fix(overrides): tests

46894c6


          chore: remove remnants of KubeFed in comments

1f1a6e8


          fix: import grouping

0ffcd27


          fix(versionmanager): remove redundant ok check


          chore: add comments to VersionManager

e42029d


          chore(versionmanager): add comments to Get

da2e3ca


          chore: FederatedResource comments

fae54e5


          refactor(sync): FederatedResource interface implements VersionedResource

efb2538


          chore(sync): add comments to FederatedResource methods

9aba3b8


          chore(sync): update FederatedResourceAccessor comments

d94304e


          chore: remove unused pkg/util/meta functions and tests

1c35b06


          refactor: move pkg/util/propagatedversion to pkg/controllers/sync/pro…

f26cf0f

…pagatedversion


          chore(sync): fix import formatting

a37b47f


          refactor(sync): avoid redundant get ftc from ftcmanager

3f62427


          refactor(sync): rename methods for clarity

cb1393d


          fix(scheduler): make it compilable

e1f722a


          fix: compile errors

3bc1119


          fix(util): broken test

9fcd4ee

gary-lgy force-pushed the unified-sync-controller branch from 56987b2 to 9fcd4ee Compare

July 31, 2023 06:08

limhawjia approved these changes

View reviewed changes


          feat: forbid overriding invalid paths

eff8b64

limhawjia approved these changes

View reviewed changes

gary-lgy merged commit 9952582 into kubewharf:refactor/unified-federated-type

1 of 5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet