refactor(auto-migration): fix typos and simplify codes

kubewharf · Jul 19, 2023 · 8c04797 · 8c04797
1 parent 84d2aff
commit 8c04797
Showing 1 changed file with 5 additions and 14 deletions.
diff --git a/pkg/controllers/automigration/controller.go b/pkg/controllers/automigration/controller.go
@@ -276,14 +276,14 @@ func (c *Controller) reconcile(ctx context.Context, qualifiedName common.Qualifi
 
 		keyedLogger.V(1).Info("Updating federated object with auto migration information", "estimatedCapacity", estimatedCapacity)
 		if qualifiedName.Namespace != "" {
-			fo := fedcorev1a1.FederatedObject(*fedObject.DeepCopy())
+			federatedObject := fedcorev1a1.FederatedObject(*fedObject.DeepCopy())
 			_, err = c.federatedObjectClient.
 				FederatedObjects(qualifiedName.Namespace).
-				Update(ctx, &fo, metav1.UpdateOptions{})
+				Update(ctx, &federatedObject, metav1.UpdateOptions{})
 		} else {
-			cfo := fedcorev1a1.ClusterFederatedObject(*fedObject.DeepCopy())
+			clusterFederatedObject := fedcorev1a1.ClusterFederatedObject(*fedObject.DeepCopy())
 			_, err = c.clusterFederatedObjectClient.
-				Update(ctx, &cfo, metav1.UpdateOptions{})
+				Update(ctx, &clusterFederatedObject, metav1.UpdateOptions{})
 		}
 
 		if err != nil {
@@ -538,16 +538,7 @@ func (c *Controller) getTargetObjectsIfAutoMigrationEnabled(
 		err = fmt.Errorf("failed to unmarshall template of federated object: %w", err)
 		return nil, nil, nil, err
 	}
-	gv, err := schema.ParseGroupVersion(objectMeta.APIVersion)
-	if err != nil {
-		err = fmt.Errorf("failed to unmarshall template of federated object: %w", err)
-		return nil, nil, nil, err
-	}
-	gvk := schema.GroupVersionKind{
-		Group:   gv.Group,
-		Version: gv.Version,
-		Kind:    objectMeta.Kind,
-	}
+	gvk := objectMeta.GroupVersionKind()
 
 	ftcList, err := c.federatedInformer.GetFederatedTypeConfigLister().List(labels.Everything())
 	if err != nil {