Skip to content

feat: support mcs #1276

feat: support mcs

feat: support mcs #1276

Triggered via pull request January 9, 2024 03:03
Status Failure
Total duration 5m 0s
Artifacts

ci.yml

on: pull_request
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 1 warning
typos
Process completed with exit code 2.
lint: pkg/controllers/mcs/service_import_controller.go#L573
Consider pre-allocating `clusterNames` (prealloc)
lint: pkg/controllers/mcs/service_export_controller.go#L241
unnecessary trailing newline (whitespace)
lint: pkg/controllers/mcs/service_export_controller.go#L482
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
lint: pkg/controllers/mcs/service_export_controller.go#L136
S1008: should use 'return managedlabel.HasManagedLabel(unstructuredObj)' instead of 'if !managedlabel.HasManagedLabel(unstructuredObj) { return false }; return true' (gosimple)
lint: pkg/controllers/common/constants.go#L27
import "k8s.io/api/discovery/v1beta1" imported as "discoveryv1beta1" but must be "discoveryv1b1" according to config (importas)
lint: pkg/controllers/mcs/service_export_controller.go#L24
import "k8s.io/api/discovery/v1beta1" imported as "discoveryv1beta1" but must be "discoveryv1b1" according to config (importas)
lint: pkg/controllers/mcs/service_export_controller.go#L33
import "k8s.io/client-go/informers/discovery/v1beta1" imported without alias but must be with alias "discoveryv1b1informers" according to config (importas)
lint: pkg/controllers/mcs/service_import_controller.go#L25
import "k8s.io/api/discovery/v1beta1" imported as "discoveryv1beta1" but must be "discoveryv1b1" according to config (importas)
lint: pkg/controllers/mcs/service_import_controller.go#L32
import "k8s.io/client-go/informers/discovery/v1beta1" imported without alias but must be with alias "discoveryv1b1informers" according to config (importas)
lint: pkg/util/informermanager/fake/federatedinformermanager.go#L26
import "k8s.io/client-go/listers/discovery/v1beta1" imported as "discoveryv1beta1listers" but must be "discoveryv1b1listers" according to config (importas)
typos: pkg/util/naming/naming_test.go#L180
"fo" should be "of" or "for" or "do" or "go" or "to".