Skip to content

refactor: follower controller #752

refactor: follower controller

refactor: follower controller #752

Triggered via pull request August 1, 2023 02:14
Status Failure
Total duration 3m 55s
Artifacts

ci.yml

on: pull_request
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

22 errors and 1 warning
typos
Process completed with exit code 2.
lint: pkg/controllers/follower/controller.go#L239
line is 142 characters (lll)
lint: pkg/controllers/follower/controller.go#L255
line is 142 characters (lll)
lint: pkg/controllers/follower/controller.go#L379
line is 144 characters (lll)
lint: pkg/controllers/follower/controller.go#L239
ineffectual assignment to ctx (ineffassign)
lint: pkg/controllers/follower/controller.go#L239
SA4006: this value of `ctx` is never used (staticcheck)
lint: pkg/controllers/follower/controller.go#L239
assigned to ctx, but never used afterwards (wastedassign)
lint
issues found
test (1.20): pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
test (1.20): pkg/controllers/automigration/util_test.go#L40
undefined: countUnschedulablePods
test (1.20): pkg/controllers/statusaggregator/plugins/job_test.go#L313
undefined: IsJobFinishedWithFailed
test (1.20)
Process completed with exit code 2.
test (1.19): pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
test (1.19): pkg/controllers/automigration/util_test.go#L40
undefined: countUnschedulablePods
test (1.19): pkg/controllers/statusaggregator/plugins/job_test.go#L313
undefined: IsJobFinishedWithFailed
test (1.19)
Process completed with exit code 2.
typos: docs/quickstart.md#L6
"propgating" should be "propagating".