Skip to content
CI

refactor(auto-migration): unify type and support pod trigger #750

Sign in to view logs

refactor(auto-migration): unify type and support pod trigger

refactor(auto-migration): unify type and support pod trigger #750

Triggered via pull request July 31, 2023 13:53
@JackZxjJackZxj
synchronize #156
JackZxj:refactor/unified-federated-type-for-automigration
Status Failure
Total duration 4m 4s
Artifacts –

ci.yml

on: pull_request
lint
1m 3s
lint
verify-codegen
31s
verify-codegen
typos
5s
typos
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

29 errors and 1 warning
typos
Process completed with exit code 2.
lint: pkg/controllers/automigration/plugins/util.go#L44
G601: Implicit memory aliasing in for loop. (gosec)
lint: pkg/controllers/automigration/plugins/util.go#L44
exporting a pointer for the loop variable o (exportloopref)
lint: pkg/controllers/automigration/plugins/util.go#L22
import "k8s.io/apimachinery/pkg/api/errors" imported without alias but must be with alias "apierrors" according to config (importas)
lint: pkg/controllers/automigration/controller.go#L236
ineffectual assignment to keyedLogger (ineffassign)
lint: pkg/controllers/automigration/controller.go#L541
naked return in func `getPossibleSourceObjectsFromCluster` with 44 lines of code (nakedret)
lint: pkg/controllers/automigration/controller.go#L236
SA4006: this value of `keyedLogger` is never used (staticcheck)
lint: pkg/controllers/automigration/plugins/util.go#L35
ST1003: func parameter ownerApiResource should be ownerAPIResource (stylecheck)
lint
issues found
test (1.20): pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
test (1.20): pkg/client/generic/genericclient.go#L161
undefined: common.LastRevisionAnnotation
test (1.20): pkg/client/generic/genericclient.go#L163
undefined: common.LastRevisionAnnotation
test (1.20): pkg/controllers/follower/util_test.go#L306
undefined: FollowerReference
test (1.20): pkg/controllers/follower/util_test.go#L309
undefined: FollowerReference
test (1.20): pkg/controllers/follower/util_test.go#L317
undefined: getFollowersFromPod
test (1.20): pkg/controllers/statusaggregator/plugins/job_test.go#L187
undefined: NewJobPlugin
test (1.20): pkg/controllers/statusaggregator/plugins/job_test.go#L313
undefined: IsJobFinishedWithFailed
test (1.20): pkg/controllers/statusaggregator/plugins/pod_test.go#L322
undefined: NewPodPlugin
test (1.20): pkg/controllers/util/federatedclient/podinformer_test.go#L209
undefined: addPodInformer
test (1.19): pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
test (1.19): pkg/client/generic/genericclient.go#L161
undefined: common.LastRevisionAnnotation
test (1.19): pkg/client/generic/genericclient.go#L163
undefined: common.LastRevisionAnnotation
test (1.19): pkg/controllers/follower/util_test.go#L306
undefined: FollowerReference
test (1.19): pkg/controllers/follower/util_test.go#L309
undefined: FollowerReference
test (1.19): pkg/controllers/follower/util_test.go#L317
undefined: getFollowersFromPod
test (1.19): pkg/controllers/statusaggregator/plugins/job_test.go#L187
undefined: NewJobPlugin
test (1.19): pkg/controllers/statusaggregator/plugins/job_test.go#L313
undefined: IsJobFinishedWithFailed
test (1.19): pkg/controllers/statusaggregator/plugins/pod_test.go#L322
undefined: NewPodPlugin
test (1.19): pkg/controllers/util/federatedclient/podinformer_test.go#L209
undefined: addPodInformer
typos: docs/quickstart.md#L6
"propgating" should be "propagating".