refactor: follower controller #742
mrlihanboAnnotations
28 errors and 1 warning
|
typos
Process completed with exit code 2.
|
|
lint:
pkg/controllers/follower/controller.go#L239
line is 142 characters (lll)
|
|
lint:
pkg/controllers/follower/controller.go#L255
line is 142 characters (lll)
|
|
lint:
pkg/controllers/follower/controller.go#L379
line is 144 characters (lll)
|
|
lint:
pkg/controllers/follower/controller.go#L239
ineffectual assignment to ctx (ineffassign)
|
|
lint:
pkg/controllers/follower/controller.go#L239
SA4006: this value of `ctx` is never used (staticcheck)
|
|
lint:
pkg/controllers/follower/controller.go#L239
assigned to ctx, but never used afterwards (wastedassign)
|
|
lint
issues found
|
|
test (1.19):
pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/util/annotation/submap_test.go#L25
no required module provides package github.com/kubewharf/kubeadmiral/pkg/controllers/util/annotation; to add it:
|
|
test (1.19):
pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/controllers/automigration/util_test.go#L40
undefined: countUnschedulablePods
|
|
test (1.19):
pkg/controllers/override/util_test.go#L301
cannot use obj (variable of type *unstructured.Unstructured) as type "github.com/kubewharf/kubeadmiral/pkg/apis/core/v1alpha1".GenericFederatedObject in argument to lookForMatchedPolicies:
|
|
test (1.19):
pkg/controllers/override/util_test.go#L301
cannot use overridePolicyStore (variable of type "k8s.io/client-go/tools/cache".Store) as type "github.com/kubewharf/kubeadmiral/pkg/client/listers/core/v1alpha1".OverridePolicyLister in argument to lookForMatchedPolicies:
|
|
test (1.19):
pkg/controllers/override/util_test.go#L301
cannot use clusterOverridePolicyStore (variable of type "k8s.io/client-go/tools/cache".Store) as type "github.com/kubewharf/kubeadmiral/pkg/client/listers/core/v1alpha1".ClusterOverridePolicyLister in argument to lookForMatchedPolicies:
|
|
test (1.19):
pkg/controllers/override/util_test.go#L328
undefined: util.OverridesMap
|
|
test (1.19):
pkg/controllers/override/util_test.go#L344
undefined: util.OverridesMap
|
|
test (1.20):
pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/util/annotation/submap_test.go#L25
no required module provides package github.com/kubewharf/kubeadmiral/pkg/controllers/util/annotation; to add it:
|
|
test (1.20):
pkg/controllers/scheduler/scheduler_test.go#L32
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/controllers/automigration/util_test.go#L40
undefined: countUnschedulablePods
|
|
test (1.20):
pkg/controllers/override/util_test.go#L301
cannot use obj (variable of type *unstructured.Unstructured) as "github.com/kubewharf/kubeadmiral/pkg/apis/core/v1alpha1".GenericFederatedObject value in argument to lookForMatchedPolicies: *unstructured.Unstructured does not implement "github.com/kubewharf/kubeadmiral/pkg/apis/core/v1alpha1".GenericFederatedObject (missing method DeepCopyGenericFederatedObject)
|
|
test (1.20):
pkg/controllers/override/util_test.go#L301
cannot use overridePolicyStore (variable of type "k8s.io/client-go/tools/cache".Store) as "github.com/kubewharf/kubeadmiral/pkg/client/listers/core/v1alpha1".OverridePolicyLister value in argument to lookForMatchedPolicies: "k8s.io/client-go/tools/cache".Store does not implement "github.com/kubewharf/kubeadmiral/pkg/client/listers/core/v1alpha1".OverridePolicyLister (wrong type for method List)
|
|
test (1.20):
pkg/controllers/override/util_test.go#L301
cannot use clusterOverridePolicyStore (variable of type "k8s.io/client-go/tools/cache".Store) as "github.com/kubewharf/kubeadmiral/pkg/client/listers/core/v1alpha1".ClusterOverridePolicyLister value in argument to lookForMatchedPolicies: "k8s.io/client-go/tools/cache".Store does not implement "github.com/kubewharf/kubeadmiral/pkg/client/listers/core/v1alpha1".ClusterOverridePolicyLister (wrong type for method Get)
|
|
test (1.20):
pkg/controllers/override/util_test.go#L328
undefined: util.OverridesMap
|
|
test (1.20):
pkg/controllers/override/util_test.go#L344
undefined: util.OverridesMap
|
|
typos:
docs/quickstart.md#L6
"propgating" should be "propagating".
|