refactor: follower controller #719
mrlihanboAnnotations
28 errors and 2 warnings
|
typos
Process completed with exit code 2.
|
|
lint:
pkg/controllers/follower/controller.go#L179
Error return value of `c.informerManager.AddFTCUpdateHandler` is not checked (errcheck)
|
|
lint:
pkg/controllers/follower/controller.go#L310
line is 142 characters (lll)
|
|
lint:
pkg/controllers/follower/controller.go#L375
Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
|
|
lint:
pkg/controllers/follower/controller.go#L294
ineffectual assignment to ctx (ineffassign)
|
|
lint:
pkg/controllers/follower/controller.go#L294
SA4006: this value of `ctx` is never used (staticcheck)
|
|
lint:
pkg/controllers/follower/controller.go#L294
assigned to ctx, but never used afterwards (wastedassign)
|
|
lint
issues found
|
|
test (1.19):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/util/annotation/submap_test.go#L25
no required module provides package github.com/kubewharf/kubeadmiral/pkg/controllers/util/annotation; to add it:
|
|
test (1.19):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/controllers/automigration/util_test.go#L40
undefined: countUnschedulablePods
|
|
test (1.19):
pkg/controllers/federatedcluster/util_test.go#L263
undefined: aggregateResources
|
|
test (1.19):
pkg/controllers/statusaggregator/plugins/job_test.go#L187
undefined: NewJobPlugin
|
|
test (1.19):
pkg/controllers/statusaggregator/plugins/job_test.go#L313
undefined: IsJobFinishedWithFailed
|
|
test (1.19):
pkg/controllers/statusaggregator/plugins/pod_test.go#L322
undefined: NewPodPlugin
|
|
test (1.20):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/util/annotation/submap_test.go#L25
no required module provides package github.com/kubewharf/kubeadmiral/pkg/controllers/util/annotation; to add it:
|
|
test (1.20):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/controllers/automigration/util_test.go#L40
undefined: countUnschedulablePods
|
|
test (1.20):
pkg/controllers/federatedcluster/util_test.go#L263
undefined: aggregateResources
|
|
test (1.20):
pkg/controllers/statusaggregator/plugins/job_test.go#L187
undefined: NewJobPlugin
|
|
test (1.20):
pkg/controllers/statusaggregator/plugins/job_test.go#L313
undefined: IsJobFinishedWithFailed
|
|
test (1.20):
pkg/controllers/statusaggregator/plugins/pod_test.go#L322
undefined: NewPodPlugin
|
|
typos:
docs/quickstart.md#L6
"propgating" should be "propagating".
|
|
typos:
pkg/util/informermanager/informermanager.go#L386
"intial" should be "initial".
|