refactor(federate-controller): refactor federate controller #627
limhawjiaAnnotations
30 errors and 5 warnings
|
typos
Process completed with exit code 2.
|
|
lint:
pkg/util/logging/logging.go#L27
File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/kubewharf/kubeadmiral) --custom-order (gci)
|
|
lint:
pkg/util/cluster/client.go#L164
File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/kubewharf/kubeadmiral) --custom-order (gci)
|
|
lint:
pkg/util/logging/logging.go#L27
File is not `gofumpt`-ed (gofumpt)
|
|
lint:
pkg/util/eventhandlers/eventhandler.go#L1
Missed header for check (goheader)
|
|
lint:
pkg/controllers/federate/controller.go#L247
S1039: unnecessary use of fmt.Sprintf (gosimple)
|
|
lint:
pkg/controllers/federate/controller.go#L222
ineffectual assignment to logger (ineffassign)
|
|
lint:
pkg/controllers/federate/controller.go#L222
SA4006: this value of `logger` is never used (staticcheck)
|
|
lint:
pkg/controllers/federate/controller.go#L31
ST1019: package "k8s.io/client-go/dynamic" is being imported more than once (stylecheck)
|
|
lint
issues found
|
|
test (1.19):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/util/annotation/submap_test.go#L25
no required module provides package github.com/kubewharf/kubeadmiral/pkg/controllers/util/annotation; to add it:
|
|
test (1.19):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.19):
pkg/controllers/automigration/util_test.go#L40
undefined: countUnschedulablePods
|
|
test (1.19):
pkg/controllers/federatedcluster/util_test.go#L263
undefined: aggregateResources
|
|
test (1.19):
pkg/controllers/follower/util_test.go#L306
undefined: FollowerReference
|
|
test (1.19):
pkg/controllers/follower/util_test.go#L309
undefined: FollowerReference
|
|
test (1.19):
pkg/controllers/follower/util_test.go#L317
undefined: getFollowersFromPod
|
|
test (1.20):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/util/annotation/submap_test.go#L25
no required module provides package github.com/kubewharf/kubeadmiral/pkg/controllers/util/annotation; to add it:
|
|
test (1.20):
pkg/controllers/override/util_test.go#L30
no required module provides package github.com/kubewharf/kubeadmiral/pkg/apis/types/v1alpha1; to add it:
|
|
test (1.20):
pkg/controllers/automigration/util_test.go#L40
undefined: countUnschedulablePods
|
|
test (1.20):
pkg/controllers/federatedcluster/util_test.go#L263
undefined: aggregateResources
|
|
test (1.20):
pkg/controllers/follower/util_test.go#L306
undefined: FollowerReference
|
|
test (1.20):
pkg/controllers/follower/util_test.go#L309
undefined: FollowerReference
|
|
test (1.20):
pkg/controllers/follower/util_test.go#L317
undefined: getFollowersFromPod
|
|
typos:
docs/quickstart.md#L6
"propgating" should be "propagating".
|
|
typos:
pkg/util/naming/naming.go#L103
"santized" should be "sanitized".
|
|
typos:
pkg/util/naming/naming.go#L108
"santized" should be "sanitized".
|
|
typos:
pkg/util/naming/naming.go#L108
"santized" should be "sanitized".
|
|
typos:
pkg/util/naming/naming.go#L111
"santized" should be "sanitized".
|