Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend/tf): add RemoveInheritedTagsVisitor #196

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SOF3
Copy link
Member

@SOF3 SOF3 commented Sep 27, 2023

Description

An inherited tag is a tag in a span/log that also appears in its parent/owning span with the same key and value.
These tags are often useless and may be removed for brevity.

Related issues

Special notes for your reviewer:

@SOF3 SOF3 requested a review from xuqingyun September 27, 2023 07:32
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (c0d92ef) 17.63% compared to head (ea03e90) 17.63%.

Files Patch % Lines
pkg/frontend/tf/defaults/step/prune_tags.go 11.36% 39 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   17.63%   17.63%           
=======================================
  Files         103      103           
  Lines        9317     9361   +44     
=======================================
+ Hits         1643     1651    +8     
- Misses       7579     7615   +36     
  Partials       95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SOF3 SOF3 removed the request for review from xuqingyun November 29, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants