Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add PolicyServer.Spec.Affinity field, refresh crds #695

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Mar 26, 2024

Description

Part of #691

Test

CI, new unit tests.

Additional Information

Tradeoff

Potential improvement

@viccuad viccuad self-assigned this Mar 26, 2024
@viccuad viccuad requested a review from a team as a code owner March 26, 2024 13:18
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.30%. Comparing base (2d164ea) to head (d3c500c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   50.58%   50.30%   -0.29%     
==========================================
  Files          26       26              
  Lines        1967     1970       +3     
==========================================
- Hits          995      991       -4     
- Misses        869      876       +7     
  Partials      103      103              
Flag Coverage Δ
integration-tests 69.24% <ø> (-1.47%) ⬇️
unit-tests 44.23% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viccuad viccuad changed the title feat: Add PolicyServer.Spec.Affinity field, refresh crds feat: Add PolicyServer.Spec.Affinity field, refresh crds Mar 26, 2024
@flavio flavio added this to the 1.12 milestone Mar 26, 2024
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavio
Copy link
Member

flavio commented Mar 26, 2024

it looks like the integration tests failed because of the old flaky test 😭

@viccuad
Copy link
Member Author

viccuad commented Mar 26, 2024

rebased onto main as needed, fixed unused usage of the new function.

@viccuad viccuad merged commit faca8b6 into kubewarden:main Mar 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants