policy server remove non standard labels #1038
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use standard naming convention for our labels (use DNS name as part of key). Also, remove non-standard labels when possible and just use the common Kubernetes labels we are now using. Signed-off-by: Flavio Castelli <[email protected]>
flavio
force-pushed
the
policy-server-remove-non-standard-labels
branch
from
e755c1f to
cc9969f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1038 +/- ##
==========================================
- Coverage 72.73% 72.62% -0.12%
==========================================
Files 30 30
Lines 3778 3781 +3
==========================================
- Hits 2748 2746 -2
- Misses 873 877 +4
- Partials 157 158 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Related issue #1052. This affects also policy-server service and deployment selectors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #1037 and it must be merged a couple of releases after 1.23 is out.
This PR removes the old non-standard labels used by Policy Server. In certain cases it replaces them using the recommended Kubernetes labels.
We cannot merge this PR right now because we could cause a downtime during a Kubewarden upgrade.
With the 1.23 release all the Policy Server workloads will have the old and the new labels set.
With the 1.24+ release, the Policy Server workloads will have only the new labels. The Policy Server Service will use only the new labels inside of its selector.
However, we don't know how quickly the new workloads (the only using only the new labels) will be rolled out by Kubernetes. At the same time, the kubewarden-controller will update the selectors of the Policy Server service. We must ensure the selector keeps working as expected while the new workloads are rolled out.