feat: questions for tolerations and affinity. #482
Conversation
Updates the questions.yaml file adding two more questions to allow users define the tolerations and affinity used in the Helm charts via Rancher UI. Signed-off-by: José Guilherme Vanz <[email protected]>
There was a problem hiding this comment.
LGTM. Yet, does the type: yaml work already?
I hit the following last time:
rancher/dashboard#10814
rancher/dashboard#10815
|
@jvanz let's give it a try to make sure everything works fine |
|
@kubewarden/kubewarden-developers , I'm trying to add questions entries to map the new configuration. But the Rancher dashboard has issues that is making this extremely hard, if not impossible. It lacks some features to make it properly. This is also highlighted by @viccuad in this comment. With the in mind, I think we should keep that out of the questions.yml until Rancher dashboard fixes the blocking issues |
|
I would suggest adding the questions but commented for now, with a link to the issues. |
I personally do not like having code not use in the file. It makes it harder to read and maintain. I would prefer update the issue and wait for the fixes. |
|
I'm ok with that, let's open an issue, and link and close this PR then. |
|
Description
Updates the questions.yaml file adding two more questions to allow users define the tolerations and affinity used in the Helm charts via Rancher UI.