Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exposes store flag from audit-scanner #360

Conversation

nnelas
Copy link
Contributor

@nnelas nnelas commented Dec 15, 2023

Description

Fix #107

As required by kubewarden/audit-scanner#107, this commit adds the new flag - store - to the kuberwarden-controller Helm chart.

Test

Tested locally using helm template charts/kubewarden-controller

Additional Information

Tradeoff

Potential improvement

As required by kubewarden/audit-scanner#107, this commit adds the new flag - `store` - to the `kuberwarden-controller` Helm chart.

Signed-off-by: Nuno Nelas <[email protected]>
@nnelas nnelas requested a review from a team as a code owner December 15, 2023 15:25
Copy link
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️ I'm blocking the merge though until we release the accompanying audit-scanner image.

@viccuad viccuad assigned viccuad and unassigned viccuad Jan 9, 2024
Copy link
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging, now there's audit-scanner v1.10.0-rc1 that will be consumed with this!
Thanks!

@viccuad viccuad merged commit 9732c46 into kubewarden:main Jan 9, 2024
@nnelas nnelas deleted the feature/107-exposes_store_flag_from_audit-scanner branch January 23, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Feature request: Add in-mem PolicyReportStore{} implementation
2 participants