Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Build and publish multi-arch images and manifest (#3586)" #3615

Closed

Conversation

akalenyu
Copy link
Collaborator

What this PR does / why we need it:
Temporarily revert until we figure out the issues in https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-containerized-data-importer-push-nightly-AMD64/1882262704693972992
Particularly:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 23, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from akalenyu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akalenyu
Copy link
Collaborator Author

/hold
/cc @nunnatsa
remove when ready

@kubevirt-bot kubevirt-bot requested a review from nunnatsa January 23, 2025 15:13
@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L labels Jan 23, 2025
@kubevirt-bot kubevirt-bot requested review from aglitke and awels January 23, 2025 15:13
@coveralls
Copy link

Coverage Status

coverage: 59.378% (+0.007%) from 59.371%
when pulling 0a07920 on akalenyu:revert-multi-arch-temporarily
into 4ef6ef7 on kubevirt:main.

@nunnatsa
Copy link
Contributor

The latest HCO nightly passed. I think we need to first merge kubevirt/project-infra#3909, then monitor the created images and HCO nightly builds, and if everything will be OK, we can close this PR.

/hold

@akalenyu
Copy link
Collaborator Author

/close

@kubevirt-bot
Copy link
Contributor

@akalenyu: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants