CNV-55859: add windows drivers on windows preference #2443
Conversation
|
@upalatucci: This pull request references CNV-55859 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@upalatucci: This pull request references CNV-55859 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -76,7 +77,7 @@ const CreateVMFooter: FC = () => { | |||
| setIsSubmitting(true); | |||
| setError(null); | |||
|
|
|||
| const vmToCreate = generateVM({ | |||
| const generatedVM = generateVM({ | |||
There was a problem hiding this comment.
it seems we are repeating the process of generating and mounting 3x in this component - can we extract it to one place?
| @@ -85,6 +86,8 @@ const CreateVMFooter: FC = () => { | |||
| targetNamespace: vmNamespaceTarget, | |||
| }); | |||
|
|
|||
| const vmToCreate = isWindowsOSVolume ? await mountWinDriversToVM(generatedVM) : generatedVM; | |||
There was a problem hiding this comment.
mounting is backed by 1-2 k8sGet sequential calls to the server. Together with setVm which is backed by k8sCreate this may hurt user experience.
| ? await mountWinDriversToVM(generatedVM) | ||
| : generatedVM; | ||
|
|
||
| await setVM(vmToCustomize); |
There was a problem hiding this comment.
the error handling assumes that the user is still on the same page waiting for the results - a notification would work in both cases
📝 Description
add drivers to the generatedVM when the preference is from windows
🎥 Demo
DRIVERS
Screen.Recording.2025-02-10.at.14.22.34.mov