CNV-55889: SSH over LoadBalancer creates Service with incorrect selector

[avivtur]

📝 Description

Replacing load balancer service selector according to: https://issues.redhat.com/browse/CNV-55889

🎥 Demo

Before:

After:

[openshift-ci-robot]

@avivtur: This pull request references CNV-55889 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

Replacing load balancer service selector according to: https://issues.redhat.com/browse/CNV-55889

🎥 Demo

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[avivtur]

/jira refresh

[openshift-ci-robot]

@avivtur: This pull request references CNV-55889 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "CNV v4.19.0" instead.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [avivtur,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sarahbx]

/hold

[sarahbx]

@avivtur when using vm.kubevirt.io/name the VM must be selected instead of the VMI

[avivtur]

@avivtur when using vm.kubevirt.io/name the VM must be selected instead of the VMI

@sarahbx what do you mean?

[sarahbx]

@avivtur when using vm.kubevirt.io/name the VM must be selected instead of the VMI

@sarahbx what do you mean?

In your example above, the VMI is referenced, not the VM.
VMI name: fedora-sapphire-piranha-33-{random-suffix}
VM name: fedora-sapphire-piranha-33

So the Pod selector would be:
vm.kubevirt.io/name: fedora-sapphire-piranha-33

[openshift-ci]

New changes are detected. LGTM label has been removed.