Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-53403: Fix object select #2343

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

upalatucci
Copy link
Member

📝 Description

if children is a react component, don't convert to string as it will give this error here in the select typehead

🎥 Demo

Screenshot 2025-01-07 at 11 00 38

FIX

Screenshot 2025-01-07 at 11 01 35

@openshift-ci openshift-ci bot requested review from avivtur and pcbailey January 7, 2025 10:01
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 7, 2025
@upalatucci upalatucci changed the title Fix object select CNV-54110: Fix object select Jan 7, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 7, 2025

@upalatucci: This pull request references CNV-54110 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

if children is a react component, don't convert to string as it will give this error here in the select typehead

🎥 Demo

Screenshot 2025-01-07 at 11 00 38

FIX

Screenshot 2025-01-07 at 11 01 35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jan 7, 2025
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 38416db into kubevirt-ui:main Jan 7, 2025
10 checks passed
@upalatucci upalatucci changed the title CNV-54110: Fix object select CNV-53403: Fix object select Jan 8, 2025
@upalatucci
Copy link
Member Author

/jira refresh

@upalatucci
Copy link
Member Author

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: cannot checkout release-4.18: error checking out "release-4.18": exit status 1 error: pathspec 'release-4.18' did not match any file(s) known to git

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants