CNV-54110: Use udn network #2342
Conversation
|
@upalatucci: This pull request references CNV-54110 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
...ews/catalog/templatescatalog/components/TemplatesCatalogDrawer/hooks/useCreateDrawerForm.tsx
Outdated
Show resolved
Hide resolved
upalatucci
force-pushed
the
use-udn-network
branch
from
fb29ab8 to
041bbdf
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| const defaultInterface = getInterfaces(draftVM)?.find( | ||
| (iface) => iface.name === DEFAULT_NETWORK_INTERFACE.name, | ||
| ); | ||
|
|
||
| if (useUDN && defaultInterface) { | ||
| delete defaultInterface.masquerade; | ||
| defaultInterface.binding = { name: UDN_BINDING_NAME }; | ||
| } |
There was a problem hiding this comment.
Does this repeat itself in the file above?
| @@ -67,6 +72,8 @@ const useCreateDrawerForm = ( | |||
| authorizedSSHKey: string, | |||
| ) => { | |||
| const { updateTabsData, updateVM } = useWizardVMContext(); | |||
|
|
|||
| const [useUDN] = useNamespaceUDN(namespace); | |||
There was a problem hiding this comment.
please pick a different naming for this, something more informative
|
/cherry-pick release-4.18 |
|
@upalatucci: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 Description
When primary udn is in the project, don't use masquete but use the udn binding
🎥 Demo