CNV-54179: Improve folder select #2340
Conversation
|
@avivtur: This pull request references CNV-54179 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
It's just my opinion, but 'Create folder ""' looks weird in the screenshot. |
@pcbailey Suggestions? |
Signed-off-by: Aviv Turgeman <[email protected]>
avivtur
force-pushed
the
folder-create-fix
branch
from
3e947d6 to
18fb54b
Compare
can we hide it if no string entered? |
There was a problem hiding this comment.
i can see there is an occurrency like
if (value === CREATE_NEW) {
Should we put
if ([CREATE_NEW, NOT_FOUND].includes(value)
??
There was a problem hiding this comment.
@avivtur - please go over this comment and adjust if needed in a followup pr
this was the state before this PR, unless you start entering input, that's why we wanted to improve it so the user would know he can create a folder |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Show create option when at all times, and fix text of create option.
🎥 Demo
After:
