-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid blinking tree view #2337
base: main
Are you sure you want to change the base?
Avoid blinking tree view #2337
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ea3000a
to
a25cc2a
Compare
a25cc2a
to
04329ea
Compare
Signed-off-by: Aviv Turgeman <[email protected]>
04329ea
to
56e40e7
Compare
/retest |
@avivtur: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 Description
Wrapping both VM list page and VM details page components with a tree-view component gives 2 different instances, which causes the tree-view unmount and mount every time we move from ns item to VM item and vice versa.
Manipulating the routes at our side is help to wrap both components with just one instance of tree-view.
NOTE: the ~new path to create a VM from YAML is not working well as
:name
identifier is catching it as a single VM name.🎥 Demo