Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid blinking tree view #2337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Dec 31, 2024

📝 Description

Wrapping both VM list page and VM details page components with a tree-view component gives 2 different instances, which causes the tree-view unmount and mount every time we move from ns item to VM item and vice versa.
Manipulating the routes at our side is help to wrap both components with just one instance of tree-view.
NOTE: the ~new path to create a VM from YAML is not working well as :name identifier is catching it as a single VM name.

🎥 Demo

Copy link
Contributor

openshift-ci bot commented Dec 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Dec 31, 2024
@avivtur avivtur force-pushed the manipulate-tree-view-routes branch from ea3000a to a25cc2a Compare January 3, 2025 00:49
@avivtur avivtur force-pushed the manipulate-tree-view-routes branch from a25cc2a to 04329ea Compare January 3, 2025 00:57
Signed-off-by: Aviv Turgeman <[email protected]>
@avivtur avivtur force-pushed the manipulate-tree-view-routes branch from 04329ea to 56e40e7 Compare January 5, 2025 14:14
@avivtur avivtur changed the title [wip] Avoid blinking tree view Avoid blinking tree view Jan 5, 2025
@avivtur
Copy link
Member Author

avivtur commented Jan 6, 2025

/retest

Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

@avivtur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/kubevirt-e2e-aws 56e40e7 link true /test kubevirt-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@avivtur
Copy link
Member Author

avivtur commented Jan 6, 2025

/hold
Changes causing tests failures as yaml create VM is missing.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix do-not-merge/hold needs-rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants