Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-53430: make examples compatible with s390x arch clusters #2328

Closed
wants to merge 1 commit into from
Closed

CNV-53430: make examples compatible with s390x arch clusters #2328

wants to merge 1 commit into from

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Dec 18, 2024 •
edited
Loading

📝 Description

This piece is not compatible with s390x arch clusters.

            features:
              acpi: {}
              smm:
                enabled: true
            firmware:
              bootloader:
                efi: {}
            machine:
              type: q35

window.SERVER_FLAGS.nodeArchitectures has info on the arch in the clusters

@openshift-ci openshift-ci bot requested review from avivtur and tnisan December 18, 2024 15:53
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 18, 2024 •
edited by openshift-ci bot
Loading

@upalatucci: This pull request references CNV-53430 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

This piece is not compatible with s390x arch clusters.

           features:
             acpi: {}
             smm:
               enabled: true
           firmware:
             bootloader:
               efi: {}
           machine:
             type: q35
       ```


window.SERVER_FLAGS.nodeArchitectures has info on the arch in the clusters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Dec 18, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 18, 2024 •
edited by openshift-ci bot
Loading

@upalatucci: This pull request references CNV-53430 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

This piece is not compatible with s390x arch clusters.

           features:
             acpi: {}
             smm:
               enabled: true
           firmware:
             bootloader:
               efi: {}
           machine:
             type: q35


window.SERVER_FLAGS.nodeArchitectures has info on the arch in the clusters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 18, 2024 •
edited by openshift-ci bot
Loading

@upalatucci: This pull request references CNV-53430 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

This piece is not compatible with s390x arch clusters.

           features:
             acpi: {}
             smm:
               enabled: true
           firmware:
             bootloader:
               efi: {}
           machine:
             type: q35

window.SERVER_FLAGS.nodeArchitectures has info on the arch in the clusters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

metalice
metalice reviewed Dec 18, 2024
View reviewed changes
src/utils/utils/utils.ts Outdated Show resolved Hide resolved
metalice
metalice reviewed Dec 18, 2024
View reviewed changes
src/templates/vm-yaml.ts Outdated Show resolved Hide resolved
spadgett
spadgett reviewed Dec 18, 2024
View reviewed changes
src/utils/utils/utils.ts
@@ -157,3 +159,17 @@ export const removeDockerPrefix = (image: string) => image?.replace(DOCKER_PREFI

export const isAllNamespaces = (namespace: string) =>
!namespace || namespace === ALL_NAMESPACES || namespace === ALL_NAMESPACES_SESSION_KEY;

export const isClusterOnS390X = !isEmpty(
(window as any).SERVER_FLAGS?.nodeArchitectures?.find((arch) => arch === S390X_ARCH),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth noting that this isn't a public API and could change. I wouldn't anticipate it changing, but it could. I'd suggest opening a management console issue to provide a supported API (and you can fallback to SERVER_FLAGS for older console versions).

@jhadvig @TheRealJon FYI, the kubevirt plugin is using window.SERVER_FLAGS.nodeArchitectures, so we should avoid removing or changing that if possible.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this issue apply to any SERVER_FLAG value? These are just available globally at runtime and could be used by any plugin, so making breaking changes to them is not very safe.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. SERVER_FLAGS are internal APIs. Any use by plugins could break in a future version.

We mention that CSS classes aren't APIs in the docs. We probably need to call out JavaScript globals as well, and perhaps anything in Redux.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Dec 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upalatucci
Copy link
Member Author

/hold

@upalatucci
Copy link
Member Author

@metalice @spadgett @TheRealJon i talked with multiple people and observed the templates in s390x and amd64 clusters. Templates do not have in their structure features firmware and machine fields, so we can remove that without logic

@upalatucci
Copy link
Member Author

closing in favor of: #2329

@upalatucci upalatucci closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealJon TheRealJon TheRealJon left review comments

@spadgett spadgett spadgett left review comments

@metalice metalice metalice approved these changes

@avivtur avivtur Awaiting requested review from avivtur

@tnisan tnisan Awaiting requested review from tnisan

Assignees

@metalice metalice

Labels
approved This issue is something we want to fix do-not-merge/hold jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@upalatucci @openshift-ci-robot @spadgett @metalice @TheRealJon