Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-51680: migrate or cancel migration and fix storage migration #2315

Merged

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Dec 13, 2024

📝 Description

  • Do not let the user run multiple storage migrations in the same VM multiple times. If the user launches a storage migration let it cancel it.
  • Fix migration to Migration in the updateVolumesStrategy field.
  • the DV destination name in multiple sequential migrations tends to become larger and larger. So I fixed that by following what the MTV team did: add to the original name mig-xxxx . In a future migration we'll re-create the suffix removing -mig-xxx and adding again -mig-yyyy

🎥 Demo

Before
Screenshot 2024-12-13 at 15 30 03

After

Screenshot 2024-12-13 at 15 27 10

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 13, 2024

@upalatucci: This pull request references CNV-51680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

  • Do not let the user to run multiple storage migrations in the same VM for multiple times. If the user launches a storage migration let it cancel it.
  • Fix migration to Migration in the updateVolumesStrategy field.
  • the DV destination name in multiple sequential migrations tends to become larger and larger. So I fixed that by following what the MTV team do: add to the original name mig-xxxx . In a future migration we'll re-create the suffix removing -mig-xxx and adding again -mig-yyyy

🎥 Demo

Before
Screenshot 2024-12-13 at 15 30 03

After

Screenshot 2024-12-13 at 15 27 10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and pcbailey December 13, 2024 14:32
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Dec 13, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 13, 2024

@upalatucci: This pull request references CNV-51680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

  • Do not let the user run multiple storage migrations in the same VM multiple times. If the user launches a storage migration let it cancel it.
  • Fix migration to Migration in the updateVolumesStrategy field.
  • the DV destination name in multiple sequential migrations tends to become larger and larger. So I fixed that by following what the MTV team did: add to the original name mig-xxxx . In a future migration we'll re-create the suffix removing -mig-xxx and adding again -mig-yyyy

🎥 Demo

Before
Screenshot 2024-12-13 at 15 30 03

After

Screenshot 2024-12-13 at 15 27 10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@upalatucci upalatucci force-pushed the fix-updateVolumesStrategy branch from fbb6aba to 6a5265a Compare December 13, 2024 14:38
@upalatucci upalatucci force-pushed the fix-updateVolumesStrategy branch from 6a5265a to 62a61c1 Compare December 13, 2024 15:39
@pcbailey
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Dec 13, 2024
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pcbailey,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3872fde into kubevirt-ui:main Dec 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants