Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-49533: Fix memory utilization percentage in vmlist #2311

Merged

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Dec 11, 2024

📝 Description

Align the utilization percentage between VM list and VM details page

VM details page for memory utilization is using the vmi memory amount and does not fetch it from the prometheus query.
This seems a smart thing to do so I do the same thing in the VM list
So now we do 4 queries in VM list and not 5. (Good for performance)

Note: use toFixed instead of round to show percentage with fixed number of digits (also with 0 ending numbers)

🎥 Demo

VM Details page

Screenshot 2024-12-11 at 15 44 05

VM List page
Screenshot 2024-12-11 at 15 44 36

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 11, 2024

@upalatucci: This pull request references CNV-49533 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "CNV v4.19.0" instead.

In response to this:

📝 Description

Align the utilization percentage between VM list and VM details page

VM details page for memory utilization is using the vmi memory amount and does not fetch it from the prometheus query.
This seems a smart thing to do so I do the same thing in the VM list
So now we do 4 queries in VM list and not 5. (Good for performance)

🎥 Demo

VM Details page

Screenshot 2024-12-11 at 15 44 05

VM List page
Screenshot 2024-12-11 at 15 44 36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Dec 11, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 11, 2024

@upalatucci: This pull request references CNV-49533 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "CNV v4.19.0" instead.

In response to this:

📝 Description

Align the utilization percentage between VM list and VM details page

VM details page for memory utilization is using the vmi memory amount and does not fetch it from the prometheus query.
This seems a smart thing to do so I do the same thing in the VM list
So now we do 4 queries in VM list and not 5. (Good for performance)

Note: use toFixed instead of round to show percentage with fixed number of digits (also with 0 ending numbers)

🎥 Demo

VM Details page

Screenshot 2024-12-11 at 15 44 05

VM List page
Screenshot 2024-12-11 at 15 44 36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Dec 11, 2024
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 66b8daa into kubevirt-ui:main Dec 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants