Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE-6265: Allow providing username & password for registry #2300

Conversation

pcbailey
Copy link
Member

@pcbailey pcbailey commented Dec 5, 2024

📝 Description

This PR adds username and password fields to the "Disk source" section of the Template drawer when "Registry" is selected as the source. The username and password are used to create a Secret which is added to the secretRef field of the registry block of the data volume template. This allows the user to pull images from private registries without having to configure a yaml document.

Jira: https://issues.redhat.com/browse/RFE-6265

🎥 Demo

registry-credentials--AFTER--2024-12-05.08-51.webm

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 5, 2024

@pcbailey: This pull request references RFE-6265 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

This PR adds username and password fields to the "Disk source" section of the Template drawer when "Registry" is selected as the source. The username and password are used to create a Secret which is added to the secretRef field of the registry block of the data volume template. This allows the user to pull images from private registries without having to configure a yaml document.

Jira: https://issues.redhat.com/browse/RFE-6265

🎥 Demo

TBD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from metalice and tnisan December 5, 2024 03:12
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Dec 5, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 5, 2024

@pcbailey: This pull request references RFE-6265 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

This PR adds username and password fields to the "Disk source" section of the Template drawer when "Registry" is selected as the source. The username and password are used to create a Secret which is added to the secretRef field of the registry block of the data volume template. This allows the user to pull images from private registries without having to configure a yaml document.

Jira: https://issues.redhat.com/browse/RFE-6265

🎥 Demo

registry-credentials--AFTER--2024-12-05.08-51.webm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey pcbailey force-pushed the feature-allow-credentials-for-registry-images branch from c3aa3db to c8c3af3 Compare December 12, 2024 15:17
@pcbailey pcbailey changed the title WIP: RFE-6265: Allow providing username & password for registry RFE-6265: Allow providing username & password for registry Dec 12, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Dec 13, 2024
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pcbailey,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6b5bc33 into kubevirt-ui:main Dec 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants