-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFE-6265: Allow providing username & password for registry #2300
RFE-6265: Allow providing username & password for registry #2300
Conversation
@pcbailey: This pull request references RFE-6265 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@pcbailey: This pull request references RFE-6265 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
c3aa3db
to
c8c3af3
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
This PR adds username and password fields to the "Disk source" section of the Template drawer when "Registry" is selected as the source. The username and password are used to create a Secret which is added to the
secretRef
field of theregistry
block of the data volume template. This allows the user to pull images from private registries without having to configure a yaml document.Jira: https://issues.redhat.com/browse/RFE-6265
🎥 Demo
registry-credentials--AFTER--2024-12-05.08-51.webm