Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-49533: Add Memory, CPU and Network usage on vm list #2299

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

upalatucci
Copy link
Member

📝 Description

Adding Network, Memory and CPU Usage in VM list

Note:

  • right now the columns are not sortable but we can add that later
  • For network we use the total usage (received + transferred)

🎥 Demo

Screenshot 2024-12-04 at 18 01 40

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 4, 2024

@upalatucci: This pull request references CNV-49533 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "CNV v4.19.0" instead.

In response to this:

📝 Description

Adding Network, Memory and CPU Usage in VM list

Note:

  • right now the columns are not sortable but we can add that later
  • For network we use the total usage (received + transferred)

🎥 Demo

Screenshot 2024-12-04 at 18 01 40

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and pcbailey December 4, 2024 17:07
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Dec 4, 2024
return <div>{totalTransferred}ps</div>;
};

export default NetworkUsage;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here u dont use memo?

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Dec 9, 2024
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 08cb06a into kubevirt-ui:main Dec 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants