Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-45822: Vm tree view 3 #2290

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Nov 28, 2024

📝 Description

This PR adds:

  • A new VM action - Move to folder to open a dialog and assign a folder to the VM for the tree view.
  • Applying folder inputs across the VM create flows
  • A display for folder in the details card
  • Removing edit labels/annotations actions

🎥 Demo

folder-location-IT-create
folder-location-template-create
move-to-folder-action
move-to-folder
move-to-folder2
folder-location-template-customization
folder-location-IT-customization
folder-details-card

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 28, 2024

@avivtur: This pull request references CNV-45822 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "CNV v4.18.0" instead.

In response to this:

📝 Description

This PR adds:

  • A new VM action - Move to folder to open a dialog and assign a folder to the VM for the tree view.
  • Applying folder inputs across the VM create flows
  • A display for folder in the details card
  • Removing edit labels/annotations actions

🎥 Demo

folder-location-IT-create
folder-location-template-create
move-to-folder-action
move-to-folder
move-to-folder2
folder-location-template-customization
folder-location-IT-customization
folder-details-card

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 28, 2024
@avivtur avivtur changed the title CNV-45822: Vm tree view 3 [WIP] CNV-45822: Vm tree view 3 Dec 1, 2024
@avivtur avivtur force-pushed the tree-view-3 branch 4 times, most recently from 5454f40 to 1712043 Compare December 3, 2024 12:09
Signed-off-by: Aviv Turgeman <[email protected]>
@avivtur avivtur changed the title [WIP] CNV-45822: Vm tree view 3 CNV-45822: Vm tree view 3 Dec 4, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use the common SelectTypeahead ? Add functionalities that we are missing there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can but the component is not working good with the search and few more things, it was just easier to implement it from the start, I will remove the original component as we have only 1 occurrence of it and replace it with the new component in a different PR

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Dec 5, 2024
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eaa7623 into kubevirt-ui:main Dec 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants