CNV-50914: Support for ephemeral nic #2261
Conversation
Signed-off-by: Matan Schatzman <[email protected]>
|
@metalice: This pull request references CNV-50914 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| { | ||
| isInterfaceEphemeral: ( | ||
| network: V1Network, | ||
| iface: V1VirtualMachineInstanceNetworkInterface, | ||
| ) => undefined | V1VirtualMachineInstanceNetworkInterface; | ||
| isPending: (network: V1Network) => boolean; | ||
| vm: V1VirtualMachine; | ||
| } |
There was a problem hiding this comment.
Why passing this function in the RowProps? I think you changed idea in the middle of the work don't you?
There was a problem hiding this comment.
just to keep the schema , to be same as isPending
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.17 |
|
@metalice: new pull request created: #2316 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 Description
Suuport for ephemeral nic. This nic is added by the machine and removed on restart. I added a label of ephemeral. Currently, this type of nic is causing the UI to crash.
🎥 Demo
Before: Crash , oh no something went wrong
After: