Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converter: add progress #813

Closed
wants to merge 5 commits into from
Closed

Conversation

bennyz
Copy link
Member

@bennyz bennyz commented Mar 19, 2024

No description provided.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 11.25000% with 213 lines in your changes are missing coverage. Please review.

Project coverage is 16.80%. Comparing base (a55e08e) to head (4aa4e01).
Report is 287 commits behind head on main.

❗ Current head 4aa4e01 differs from pull request most recent head 5f7da10. Consider uploading reports for the commit 5f7da10 to get more accurate results

Files Patch % Lines
pkg/controller/plan/adapter/converter.go 14.89% 80 Missing ⚠️
pkg/controller/plan/migration.go 0.00% 67 Missing ⚠️
cmd/image-converter/image-converter.go 19.40% 53 Missing and 1 partial ⚠️
pkg/controller/plan/adapter/openstack/builder.go 0.00% 5 Missing ⚠️
pkg/controller/plan/adapter/ocp/builder.go 0.00% 2 Missing ⚠️
pkg/controller/plan/adapter/ova/builder.go 0.00% 2 Missing ⚠️
pkg/controller/plan/adapter/ovirt/builder.go 0.00% 2 Missing ⚠️
pkg/controller/plan/kubevirt.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main     #813       +/-   ##
=========================================
+ Coverage      0   16.80%   +16.80%     
=========================================
  Files         0       94       +94     
  Lines         0    19685    +19685     
=========================================
+ Hits          0     3308     +3308     
- Misses        0    16109    +16109     
- Partials      0      268      +268     
Flag Coverage Δ
unittests 16.80% <11.25%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bennyz bennyz force-pushed the image-converter-progress branch 4 times, most recently from 760c3dd to ecc5469 Compare March 20, 2024 12:35
}

if workload.ImageID == "" {
//nolint:nilnil
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps I should use a sentinel error?

@bennyz bennyz force-pushed the image-converter-progress branch 7 times, most recently from fed06f9 to 4aa4e01 Compare March 24, 2024 12:50
Signed-off-by: Benny Zlotnik <[email protected]>
Signed-off-by: Benny Zlotnik <[email protected]>
Signed-off-by: Benny Zlotnik <[email protected]>
Signed-off-by: Benny Zlotnik <[email protected]>
Signed-off-by: Benny Zlotnik <[email protected]>
Copy link

sonarcloud bot commented Apr 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
7.7% Duplication on New Code

See analysis details on SonarCloud

@bennyz bennyz marked this pull request as ready for review April 7, 2024 14:27
@yaacov
Copy link
Member

yaacov commented Oct 27, 2024

@bennyz @mnecas hi, this looks important, due to @bennyz capacity, do we want to update and merge this PR, or do a new PR, because updating this one is too time consuming, when we have more capacity ?

@bennyz
Copy link
Member Author

bennyz commented Oct 27, 2024

given the focus shifted away from openstack I would not consider this important

@yaacov yaacov closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants