fix remaining linter warnings #766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
force-pushed
the
linter-sequel
branch
2 times, most recently
from
c288364
to
d71bae5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
=========================================
+ Coverage 0 16.84% +16.84%
=========================================
Files 0 88 +88
Lines 0 17896 +17896
=========================================
+ Hits 0 3014 +3014
- Misses 0 14638 +14638
- Partials 0 244 +244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bennyz
force-pushed
the
linter-sequel
branch
3 times, most recently
from
cfff9be
to
b6fe103
Compare
Signed-off-by: Benny Zlotnik <[email protected]>
bennyz
force-pushed
the
linter-sequel
branch
from
b6fe103
to
dc7cb7c
Compare
|
ahadas
reviewed
Feb 29, 2024
|
|
||
| metrics.StartPrometheusEndpoint("8443", "", certsDirectory) |
There was a problem hiding this comment.
did you change the port to 8443 on purpose?
| @@ -490,7 +489,7 @@ func getResourceCapacity(capacity int64, units string) (int64, error) { | |||
| for i := range items { | |||
| item := strings.TrimSpace(items[i]) | |||
| if i == 0 && len(item) > 0 && item != "byte" { | |||
| return 0, errors.New(fmt.Sprintf("units '%s' are invalid, only 'byte' is supported", units)) | |||
| return 0, fmt.Errorf(fmt.Sprintf("units '%s' are invalid, only 'byte' is supported", units)) | |||
There was a problem hiding this comment.
Suggested change
| return 0, fmt.Errorf(fmt.Sprintf("units '%s' are invalid, only 'byte' is supported", units)) | |
| return 0, fmt.Errorf("units '%s' are invalid, only 'byte' is supported", units) |
| @@ -502,15 +501,15 @@ func getResourceCapacity(capacity int64, units string) (int64, error) { | |||
| } | |||
| nums := strings.Split(item, "^") | |||
| if len(nums) != 2 { | |||
| return 0, errors.New(fmt.Sprintf("units '%s' are invalid, item is invalid: %s", units, item)) | |||
| return 0, fmt.Errorf(fmt.Sprintf("units '%s' are invalid, item is invalid: %s", units, item)) | |||
There was a problem hiding this comment.
Suggested change
| return 0, fmt.Errorf(fmt.Sprintf("units '%s' are invalid, item is invalid: %s", units, item)) | |
| return 0, fmt.Errorf("units '%s' are invalid, item is invalid: %s", units, item) |
| } | ||
| base, err := strconv.Atoi(nums[0]) | ||
| if err != nil { | ||
| return 0, errors.New(fmt.Sprintf("units '%s' are invalid, base component is invalid: %s", units, item)) | ||
| return 0, fmt.Errorf(fmt.Sprintf("units '%s' are invalid, base component is invalid: %s", units, item)) |
There was a problem hiding this comment.
Suggested change
| return 0, fmt.Errorf(fmt.Sprintf("units '%s' are invalid, base component is invalid: %s", units, item)) | |
| return 0, fmt.Errorf("units '%s' are invalid, base component is invalid: %s", units, item) |
| } | ||
| pow, err := strconv.Atoi(nums[1]) | ||
| if err != nil { | ||
| return 0, errors.New(fmt.Sprintf("units '%s' are invalid, pow component is invalid: %s", units, item)) | ||
| return 0, fmt.Errorf(fmt.Sprintf("units '%s' are invalid, pow component is invalid: %s", units, item)) |
There was a problem hiding this comment.
Suggested change
| return 0, fmt.Errorf(fmt.Sprintf("units '%s' are invalid, pow component is invalid: %s", units, item)) | |
| return 0, fmt.Errorf("units '%s' are invalid, pow component is invalid: %s", units, item) |
| err = tx.End() | ||
| if err != nil { | ||
| err = liberr.Wrap(err) | ||
| } |
There was a problem hiding this comment.
is it really recommended to set the error that within a go-routine?...
| @@ -356,7 +356,15 @@ func (r *Collector) getUpdates(ctx context.Context) error { | |||
| if err != nil { | |||
| return liberr.Wrap(err) | |||
| } | |||
| defer pc.Destroy(context.Background()) | |||
| defer func() { | |||
| err = pc.Destroy(context.Background()) | |||
There was a problem hiding this comment.
same question here - wouldn't it make sense to use a new variable?
| go r.manager.Start(ctx) | ||
|
|
||
| go func() { | ||
| err = r.manager.Start(ctx) |
| @@ -1032,14 +1032,14 @@ func TestWatch(t *testing.T) { | |||
| for i := 0; i < N; i++ { | |||
| switch action { | |||
| case Created: | |||
| created = append( | |||
| _ = append( | |||
| created, | ||
| TestEvent{ | ||
| action: action, | ||
| model: &TestObject{ID: i}, | ||
| }) | ||
| case Updated: | ||
| updated = append( | ||
| _ = append( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.