Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix virt-v2v bracket #503

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Fix virt-v2v bracket #503

merged 1 commit into from
Aug 7, 2023

Conversation

liranr23
Copy link
Member

@liranr23 liranr23 commented Aug 7, 2023

fixing the error in the entrypoint script:
line 5: [: missing `]'

fixing the error in the entrypoint script:
line 5: [: missing `]'

Signed-off-by: Liran Rotenberg <[email protected]>
@liranr23 liranr23 requested a review from nyoxi as a code owner August 7, 2023 07:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.7% 8.7% Duplication

@ahadas ahadas added this to the v2.5.0 milestone Aug 7, 2023
Copy link
Member

@ahadas ahadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I noticed that error in the log and forgot about it
simple enough - please backport

@ahadas
Copy link
Member

ahadas commented Aug 7, 2023

btw, another side effect of the recent changes is that we set that V2V_source to vCenter also when we convert the image after CDI fetches the image from vSphere which is confusing
cc @bkhizgiy

@ahadas
Copy link
Member

ahadas commented Aug 7, 2023

btw, another side effect of the recent changes is that we set that V2V_source to vCenter also when we convert the image after CDI fetches the image from vSphere which is confusing cc @bkhizgiy

posted #504

@ahadas ahadas merged commit e7a874e into kubev2v:main Aug 7, 2023
@liranr23 liranr23 deleted the fix_bracket branch August 7, 2023 07:32
@ahadas ahadas removed this from the v2.5.0 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants