Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: containerfiles now are building local code #1063

Closed

Conversation

ernesgonzalez33
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Sep 20, 2024

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.28%. Comparing base (8f9ec29) to head (8ce5b4a).
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1063   +/-   ##
=======================================
  Coverage   16.28%   16.28%           
=======================================
  Files         112      112           
  Lines       19771    19771           
=======================================
  Hits         3220     3220           
  Misses      16267    16267           
  Partials      284      284           
Flag Coverage Δ
unittests 16.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github.com/konveyor/forklift-controller is a Golang package inside the project.
So it is built locally, and it has historical reasons for this.

@mnecas mnecas closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants