Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE - linux: A generic approach to try to keep the ifname if… #1009

Closed
wants to merge 3 commits into from

Conversation

fabiand
Copy link
Contributor

@fabiand fabiand commented Sep 2, 2024

… possible

This works by looking in ifcfg, network manager to find ifname/macaddr mappings, and then write udev files for those.

… possible

This works by looking in ifcfg, network manager to find ifname/macaddr mappings,
and then write udev files for those.

Signed-off-by: Fabian Deutsch <[email protected]>
Signed-off-by: Fabian Deutsch <[email protected]>
Signed-off-by: Fabian Deutsch <[email protected]>
Copy link

sonarcloud bot commented Sep 10, 2024

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.44%. Comparing base (b1a1cca) to head (651ab4c).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
- Coverage   16.44%   16.44%   -0.01%     
==========================================
  Files         107      107              
  Lines       19648    19645       -3     
==========================================
- Hits         3231     3230       -1     
+ Misses      16130    16127       -3     
- Partials      287      288       +1     
Flag Coverage Δ
unittests 16.44% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiand
Copy link
Contributor Author

fabiand commented Sep 23, 2024

Closing, because we will go with a different approach.

@fabiand fabiand closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant