refactor: use lodash sequence

kubeshop · Feb 3, 2022 · a3205be · a3205be
1 parent 29903c0
commit a3205be
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/src/navsections/sectionBlueprintMiddleware.ts b/src/navsections/sectionBlueprintMiddleware.ts
@@ -1,6 +1,7 @@
 import {shallowEqual} from 'react-redux';
 
 import asyncLib from 'async';
+import _ from 'lodash';
 import log from 'loglevel';
 import {Middleware} from 'redux';
 
@@ -273,10 +274,18 @@ const processSectionBlueprints = async (state: RootState, dispatch: AppDispatch)
       ...g,
       visibleItemIds: g.itemIds.filter(itemId => itemInstanceMap[itemId].isVisible === true),
     }));
-    const visibleItemIds = itemInstances?.filter(i => i.isVisible === true).map(i => i.id) || [];
+    const visibleItemIds = itemInstances
+      ? _(itemInstances)
+          .filter(i => i.isVisible === true)
+          .map(i => i.id)
+          .value()
+      : [];
     const visibleGroupIds = sectionBlueprint.customization?.emptyGroupText
       ? sectionInstanceGroups.map(g => g.id)
-      : sectionInstanceGroups.filter(g => g.visibleItemIds.length > 0).map(g => g.id);
+      : _(sectionInstanceGroups)
+          .filter(g => g.visibleItemIds.length > 0)
+          .map(g => g.id)
+          .value();
     const sectionInstance: SectionInstance = {
       id: sectionBlueprint.id,
       rootSectionId: sectionBlueprint.rootSectionId,