support starting a reconciliation task with cron schedule #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amir Malka <[email protected]>
Signed-off-by: Amir Malka <[email protected]>
Signed-off-by: Amir Malka <[email protected]>
|
Summary:
|
|
I am a bit concerned by the old package... maybe we should consider https://github.com/go-co-op/gocron instead |
matthyx
reviewed
Oct 2, 2024
adapters/backend/v1/adapter.go
Outdated
| adapter: a, | ||
| } | ||
|
|
||
| if cfg.CronSchedule != "" { |
There was a problem hiding this comment.
I would instantiate another ticker instead of rewriting a new branch of code.
Please take a look at https://github.com/krayzpipes/cronticker/blob/main/cronticker/ticker.go (maybe we can just copy/paste this ticker and use the other cron package for our needs)
There was a problem hiding this comment.
@amirmalka PTAL at my proposal
Signed-off-by: Matthias Bertschy <[email protected]>
|
Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview