Generate NP from NetworkNeighborhood #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 30, 2024 12:14
Signed-off-by: David Wertenteil <[email protected]>
Signed-off-by: David Wertenteil <[email protected]>
Signed-off-by: David Wertenteil <[email protected]>
Signed-off-by: David Wertenteil <[email protected]>
Signed-off-by: David Wertenteil <[email protected]>
Signed-off-by: David Wertenteil <[email protected]>
Signed-off-by: David Wertenteil <[email protected]>
|
Summary:
|
matthyx
requested changes
Jun 10, 2024
| return generatedNetworkPolicy, nil | ||
| } | ||
|
|
||
| func listIngressNetworkNeighbors(nn *softwarecomposition.NetworkNeighborhood) []softwarecomposition.NetworkNeighbor { |
There was a problem hiding this comment.
so this is all the magic happening here :)
Signed-off-by: David Wertenteil <[email protected]>
|
Summary:
|
matthyx
approved these changes
Jun 17, 2024
|
Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in deprecating the NetworkNeighbors object. Next, we need to adjust the process for generating the NP using kubectl to utilize NetworkNeighborhood instead of NetworkNeighbors. This is somewhat more complex because the scope of a NetworkNeighborhood represents a replica, while the generated NP represents a workload. We'll need to determine the best way to address this. For now, I will not work on that due to time constraints.