Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/service discovery #228

Merged
merged 12 commits into from
Jul 9, 2024
Merged

Feature/service discovery #228

merged 12 commits into from
Jul 9, 2024

Conversation

idohuber
Copy link
Contributor

@idohuber idohuber commented Jun 27, 2024 •
edited
Loading

Overview

This PR adds #
service scanner for applications authentication security

Signed Commits

  • Yes, I signed my commits.
  • dont know if it is enough tests
  • didnt test on scale - big amount of services

@idohuber idohuber requested a review from matthyx June 27, 2024 12:42
@idohuber
add tests
fb88f4b 
Signed-off-by: idohu <[email protected]>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

matthyx
matthyx requested changes Jun 28, 2024
View reviewed changes
@idohuber
fix cr rejects
dc7f2ca 
Signed-off-by: idohu <[email protected]>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

matthyx
matthyx requested changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've improved the tests, see if you can make them run without commenting the NoErrors

@matthyx matthyx force-pushed the feature/service_discovery branch from 5ba7740 to e0a0653 Compare July 8, 2024 08:44
matthyx
matthyx previously approved these changes Jul 8, 2024
View reviewed changes
@matthyx matthyx requested a review from RinaO1234 July 8, 2024 08:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@idohuber
delete local scale test files
c859933 
Signed-off-by: idohu <[email protected]>

improve tests

Signed-off-by: Matthias Bertschy <[email protected]>

service_test: added a one time delete engine and checking before creatimg(no apply option)

Signed-off-by: idohu <[email protected]>

fix cr + change scan result handaling

Signed-off-by: idohu <[email protected]>
@idohuber idohuber force-pushed the feature/service_discovery branch from 81e420b to c859933 Compare July 9, 2024 11:35
@idohuber idohuber requested a review from matthyx July 9, 2024 11:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@matthyx matthyx added the release Create release label Jul 9, 2024
@matthyx matthyx merged commit 35b341f into main Jul 9, 2024
8 checks passed
@matthyx matthyx deleted the feature/service_discovery branch July 9, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RinaO1234 RinaO1234 RinaO1234 left review comments

@matthyx matthyx matthyx approved these changes

Assignees
No one assigned
Labels
release Create release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idohuber @matthyx @RinaO1234