solved locked routine when image has more than 1 tag

[matthyx]

Type

bug_fix, enhancement

---

Description

• Corrected spelling mistakes in error messages and comments.
• Changed slice initialization for clarity and consistency.
• Updated createTriggerRequestConfigMap and setCronJobTemplate functions to remove unnecessary parameters.
• Fixed incorrect logging message during image scanning.
• Improved error handling and logging for the process of scanning image tags.

---

Changes walkthrough

Relevant files

Enhancement

imageregistryhandler.go Refactoring and Bug Fixes in Image Registry Handler            mainhandler/imageregistryhandler.go Fixed typos in error messages and comments. Simplified slice initialization. Removed unnecessary parameters in createTriggerRequestConfigMap and setCronJobTemplate functions. Corrected log message from "repoes" to "repos". Enhanced error handling and logging for image tag scanning. +16/-21  imageregistryhandlerhelper.go Update ConfigMap Creation Call to Match New Signature        mainhandler/imageregistryhandlerhelper.go Updated createTriggerRequestConfigMap call to match its new signature. +1/-1

---

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-free]

PR Description updated to latest commit (0c64b62)

[codiumai-pr-agent-free]

PR Review

⏱️ Estimated effort to review [1-5]	2, because the changes are mostly straightforward, involving spelling corrections, refactoring for clarity, and parameter adjustments. The logic seems to remain largely unchanged, making it easier to review.
🧪 Relevant tests	No
🔍 Possible issues	Possible Bug: The change from []string{} to var tags []string inside loops might unintentionally shadow the outer tags variable, especially in the setImageToTagsMap function. This could lead to logical errors where the intended operations on the outer tags variable are instead performed on a new, shadowed tags variable within the loop's scope.
	Refactoring Concern: The removal of parameters in the createTriggerRequestConfigMap and setCronJobTemplate functions simplifies the interface but requires careful validation to ensure that all calls to these functions throughout the codebase have been correctly updated to match the new signatures.
🔒 Security concerns	No

---

✨ Review tool usage guide:

---

Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

• When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

• With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.

[codiumai-pr-agent-free]

PR Code Suggestions

Category	Suggestions
Best practice	Handle errors returned by function calls instead of ignoring them. Consider handling the error returned by regCommon.GetRegistryKind instead of ignoring it. This can help in identifying issues with fetching the registry kind early on. mainhandler/imageregistryhandler.go [213] -reg.Kind, _ = regCommon.GetRegistryKind(strings.Split(reg.Registry, "/")[0]) +var err error +reg.Kind, err = regCommon.GetRegistryKind(strings.Split(reg.Registry, "/")[0]) +if err != nil { + return err +}
	Initialize maps before assignment to avoid panics. It's a good practice to check if the map configMap.Data is initialized before assigning values to it to avoid potential nil map assignment panics. mainhandler/imageregistryhandler.go [301] +if configMap.Data == nil { + configMap.Data = make(map[string]string) +} configMap.Data[requestBodyFile] = command
	Use fmt.Errorf for creating error messages with dynamic content. Use fmt.Errorf to include dynamic values within error messages instead of errorWithDocumentationRef for consistency and to leverage Go's standard error handling. mainhandler/imageregistryhandler.go [370-372] errMsg := fmt.Sprintf("image %s has %d tags. scanning only first %d tags - %s", repo, tagsForDigestLen, *tagsDepth, strings.Join(tagsForDigest[:*tagsDepth], ",")) if sender != nil { - err := errorWithDocumentationRef(errMsg) + err := fmt.Errorf(errMsg)
Maintainability	Avoid variable shadowing within the same function. Instead of redeclaring var tags []string inside the if block, consider using the tags variable declared at the start of the function to avoid shadowing and potential confusion. mainhandler/imageregistryhandler.go [351-357] var tags []string if latestTags, err := iRegistry.GetLatestTags(repo, *tagsDepth, options...); err == nil { - var tags []string
Readability	Use descriptive variable names for better readability. Consider using a more descriptive variable name than c for the range variable in the loop. This enhances code readability. mainhandler/imageregistryhandler.go [767-768] -for _, c := range registriesConfigs { - if c.Registry == registryInfo.RegistryName { +for _, config := range registriesConfigs { + if config.Registry == registryInfo.RegistryName {

---

✨ Improve tool usage guide:

---

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

• When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

• With a configuration file, use the following template:

[pr_code_suggestions]
some_config1=...
some_config2=...

See the improve usage page for a comprehensive guide on using this tool.

[github-actions]

Summary:

• License scan: failure
• Credentials scan: failure
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success

[dwertent]

Was this the issue?

[matthyx]

yes