Error handling, restored commented-out code

[amirmalka]

type:

bug_fix

---

description:

This PR includes several changes aimed at improving error handling in the codebase. It also restores some previously commented-out code. The main changes are:

• Added error handling for the deleteCRDs and triggerScanFor functions in handlers.go.
• Added error handling for the Handle function in service.go.
• Restored previously commented-out error handling code in watcher.go.
• Changed log level from Info to Error in several places in imageregistryhandlerhelper.go to better reflect the severity of the situation.
• Ignored error check in service_test.go for createUnstructuredPod function.

---

main_files_walkthrough:

files:

• continuousscanning/handlers.go: Added error handling for the deleteCRDs and triggerScanFor functions.
• continuousscanning/service.go: Added error handling for the Handle function.
• watcher/watcher.go: Restored previously commented-out error handling code.
• mainhandler/imageregistryhandlerhelper.go: Changed log level from Info to Error in several places to better reflect the severity of the situation.
• continuousscanning/service_test.go: Ignored error check for createUnstructuredPod function.

---

User Description:

Overview

This PR fixes #

Signed Commits

• Yes, I signed my commits.

[codiumai-pr-agent-free]

PR Analysis

• 🎯 Main theme: Error handling and restoring commented-out code
• 📝 PR summary: This PR primarily focuses on improving error handling across several functions in the codebase. It also restores some previously commented-out code. The changes include adding error handling for functions in handlers.go and service.go, restoring error handling code in watcher.go, changing log levels in imageregistryhandlerhelper.go, and ignoring error checks in service_test.go.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 3, because the PR involves changes in multiple files and functions, and the reviewer needs to understand the context and impact of these changes.
• 🔒 Security concerns: No security concerns found

PR Feedback

• 💡 General suggestions: The PR has made good strides in improving error handling across the codebase. However, it would be beneficial to add tests that specifically verify the new error handling logic. Additionally, it would be helpful to ensure that all errors are handled appropriately and not just logged and ignored.

• 🤖 Code feedback:

  • relevant file: continuousscanning/handlers.go
    suggestion: Consider returning the error after logging it instead of just logging. This would allow the calling function to decide how to handle the error. [important]
    relevant line: logger.L().Ctx(ctx).Error("failed to delete CRDs", helpers.Error(err))

  • relevant file: continuousscanning/service.go
    suggestion: Similar to the previous suggestion, consider returning the error after logging it. This would allow the calling function to decide how to handle the error. [important]
    relevant line: logger.L().Ctx(ctx).Error(

  • relevant file: continuousscanning/service_test.go
    suggestion: Ignoring errors can lead to hidden bugs. It's better to handle the error and fail the test if necessary. [important]
    relevant line: createUnstructuredPod(t, ctx, dynClient, podsGvr, namespaceStub, pod, createOpts) //nolint: errcheck

  • relevant file: watcher/watcher.go
    suggestion: It's good to see the restoration of error handling code. However, consider adding a comment explaining why the error is being sent to the error channel. [medium]
    relevant line: err := wh.storageClient.SpdxV1beta1().VulnerabilityManifests(obj.ObjectMeta.Namespace).Delete(context.TODO(), manifestName, v1.DeleteOptions{})

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

[github-actions]

Summary:

• License scan: success
• Credentials scan: success
• Vulnerabilities scan: success
• Unit test: success
• Go linting: success