Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove storage classes in templates to avoid errors #409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mms-gianni
Copy link
Member

@mms-gianni mms-gianni commented Sep 18, 2024

Description

Having "standard" storageclass in the templates might fail on some Providers, when no "standard" is available.

Better to have them empty, and avoid submitting a faulty template.

Type of change

Please delete options that are not relevant.

  • Template (non-breaking change which adds a template)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I've built the image and tested it on a kubernetes cluster

Test Configuration:

  • Operator Version: N/A
  • Kubernetes Version: N/A
  • Kubero CLI Version (if applicable): N/A

Checklist:

  • I removed unnecessary debug logs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I documented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@mms-gianni mms-gianni self-assigned this Sep 19, 2024
@mms-gianni mms-gianni added the bug Something isn't working label Sep 19, 2024
@mms-gianni mms-gianni added this to the v2.4.2 milestone Sep 19, 2024
@mms-gianni mms-gianni changed the base branch from main to release/v2.4.2 September 27, 2024 10:04
@mms-gianni mms-gianni changed the base branch from release/v2.4.2 to main September 27, 2024 10:04
@mms-gianni mms-gianni removed this from the v2.4.2 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant